Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapped npm releasing in Travis config #23

Closed
wants to merge 5 commits into from
Closed

Bootstrapped npm releasing in Travis config #23

wants to merge 5 commits into from

Conversation

tobbbles
Copy link
Collaborator

Closes #22.

@liamcurry / @welps you'll need to encrypt and set up your npm api key, you can read the docs for this at https://docs.travis-ci.com/user/deployment/npm

Hopefully this will streamline releasing. 😎

@tobbbles tobbbles closed this Jan 20, 2016
@tobbbles
Copy link
Collaborator Author

@welps @liamcurry

I got a bit carried away with my interpretations of where the package is to head. I apologies for this, and ask you both for feedback and my ideas for a future roadmap.

What I've done:

  • Switched the test suite to AVA (http:/sindresorhus/ava)
  • Added my own personal account to the Travis deployment system (I want this to change, although I'm not sure how Travis can differentiate between the contributor who releases a new version)
  • Created a production branch, which will be deployed to NPM
  • Set Travis/NPM deployment to run off of git tags

Future implementation:

  • Bundle background image URL into profile

@welps
Copy link
Collaborator

welps commented Jan 20, 2016

Hey, no apologies! Thanks for taking the time to do this.

AVA seems good, I've only used Jasmine/Mocha/chai so I'll have to pick it up.

I'd make the following configuration changes for AVA in package.json. It should fail after the first text and be verbose (mostly so it's easier to glance at Travis CI)

"ava": {
    "failFast": true,
    "verbose": true
},

For the test names, I think you can omit ">>" and the name before it since the file name is included in the report.

 ✔ index › Module >> version type
 ✔ strategy › Strategy >> _providerURL
 ✔ strategy › Strategy >> name

For Travis -> npm, I think it's fine if we use your account. I have no issues with this. Don't believe Travis has a solution for differentiating (or maybe everyone has to maintain their own .travis.yml) so let's keep it simple.

I'm okay with everything else! You should probably feel free to merge this in whenever you're ready since I think @liamcurry is okay with us just taking care of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants