PWX-37844 : Restarting portworx pods when vsphere secret is changed #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 75.97% 76.05% +0.08%
==========================================
Files 77 77
Lines 20600 20730 +130
==========================================
+ Hits 15650 15766 +116
- Misses 3853 3869 +16
+ Partials 1097 1095 -2 ☔ View full report in Codecov by Sentry. |
|
This PR is stale because it has been in review for 3 days with no activity. |
|
This PR is stale because it has been open for 90 days with no activity. Update this PR or it will be automatically closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Currently when wrong vsphere secret values are used, px fails to come up. But if the secret is updated, px still fails to come up as the old env variables are still mounted on the container. Solution is to restart all px pods when secret is changed. In the PR, operator keeps comparing the resource versions of the vsphere secret and when it changes, triggers the restart of px pods.
Which issue(s) this PR fixes (optional)
Closes # PWX-37844
Special notes for your reviewer: Everytime operator restarts, the older resource version becomes nil and the operator might assume the resource version has changed. To tackle this, the value of secret is first fetched when the operator is initialised. However there is an edge case where operator is restarting and secret gets updated then. Since operator takes 1second to restart this is a very rare occurance.