Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define GitOps Spec without interface{} #1609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dgoel-px
Copy link

@dgoel-px dgoel-px commented Jul 16, 2024

What this PR does / why we need it:
Codegen fails if interface{} is used with

Generating deepcopy funcs
F0716 23:46:57.357189   17804 deepcopy.go:759] DeepCopy of "interface{}" is unsupported. Instead, use named interfaces with DeepCopy<named-interface> as one of the methods.
Makefile:175: recipe for target 'codegen' failed

Now fixed

root@dgoel-dev-0:~/git/go/src/github.com/libopenstorage/operator (fix_gitops_rm_interface)$ make codegen
go run sigs.k8s.io/controller-tools/cmd/controller-gen object paths="./pkg/apis/portworx/..."
go run sigs.k8s.io/controller-tools/cmd/controller-gen crd:generateEmbeddedObjectMeta=true paths="./pkg/apis/portworx/..." output:crd:artifacts:config=deploy/crds
Generating CRD
(GOFLAGS="" hack/update-codegen.sh)
Generating deepcopy funcs
Generating clientset for core:v1 portworx:v1 at github.com/libopenstorage/operator/pkg/client/clientset
Generating listers for core:v1 portworx:v1 at github.com/libopenstorage/operator/pkg/client/listers
Generating informers for core:v1 portworx:v1 at github.com/libopenstorage/operator/pkg/client/informers
root@dgoel-dev-0:~/git/go/src/github.com/libopenstorage/operator (fix_gitops_rm_interface)$ go test -v -run ^TestAutopilot github.com/libopenstorage/operator/drivers/storage/portworx > test.out
root@dgoel-dev-0:~/git/go/src/github.com/libopenstorage/operator (fix_gitops_rm_interface)$ grep "\-\-\- PASS: TestAutopilot" test.out
--- PASS: TestAutopilotInstall (0.03s)
--- PASS: TestAutopilotInstallIncorrectSpec (0.00s)
--- PASS: TestAutopilotWithoutImage (0.00s)
--- PASS: TestAutopilotWithEnvironmentVariables (0.00s)
--- PASS: TestAutopilotWithTLSEnabled (0.02s)
--- PASS: TestAutopilotWithDesiredImage (0.01s)
--- PASS: TestAutopilotImageChange (0.01s)
--- PASS: TestAutopilotArgumentsChange (0.01s)
--- PASS: TestAutopilotConfigArgumentsChange (0.00s)
--- PASS: TestAutopilotEnvVarsChange (0.01s)
--- PASS: TestAutopilotResources (0.01s)
--- PASS: TestAutopilotCPUChange (0.00s)
--- PASS: TestAutopilotInvalidCPU (0.00s)
--- PASS: TestAutopilotSecurityContext (0.00s)
--- PASS: TestAutopilotVolumesChange (0.04s)
--- PASS: TestAutopilotInstallAndUninstallOnOpenshift414 (0.01s)
--- PASS: TestAutopilotWithOCPSecretNotFound (0.01s)
--- PASS: TestAutopilotProviderURLOnOCP414 (0.00s)
--- PASS: TestAutopilotInstallAndUninstallOnOpenshift415 (0.01s)

@dgoel-px dgoel-px changed the title Define GitOps Spec declaratively Define GitOps Spec without interface{} Jul 17, 2024
@piyush-nimbalkar piyush-nimbalkar requested a review from a team July 17, 2024 16:41
Copy link

This PR is stale because it has been in review for 3 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants