PWX-38541 | Add GitHub Actions to Enforce Sync Between StorageCluster CRD and Helm Templates #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitesh-wani-px
requested review from
nikita-bhatia,
diptiranjanpx and
svijaykumar-px
hitesh-wani-px
force-pushed
the
PWX-38541
branch
from
4644584
to
3b21d89
Compare
Signed-off-by: hitesh-wani-px <[email protected]>
hitesh-wani-px
force-pushed
the
PWX-38541
branch
from
3b21d89
to
16524e4
Compare
…ile for user configurable field changes Signed-off-by: hitesh-wani-px <[email protected]>
hitesh-wani-px
force-pushed
the
PWX-38541
branch
12 times, most recently
from
fa995c2
to
a24abc9
Compare
Signed-off-by: hitesh-wani-px <[email protected]>
hitesh-wani-px
force-pushed
the
PWX-38541
branch
from
a24abc9
to
18e668f
Compare
|
This PR is stale because it has been in review for 3 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements a GitHub Actions workflow to validate synchronization between changes in the StorageCluster CRD and the corresponding Helm storagecluster CRD and template.
If changes are detected in
deploy/crds/core_v1_storagecluster_crd.yamlfile, the its required ti include following in the PR description:HELM_PR_LINK = <your helm PR>values.yamlIS_USER_CONFIGURABLE_FIELD_ADDED = YES | NOIS_USER_CONFIGURABLE_FIELD_ADDEDto YES if the field is configurable or editable by the user.IS_USER_CONFIGURABLE_FIELD_ADDEDto NO if the field is not configurable by the user.Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PWX-38541
Special notes for your reviewer: