Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-38400 : Do not attempt to delete plugin on non-openshift clusters #1655

Open
wants to merge 1 commit into
base: release-24.2.0
Choose a base branch
from

Conversation

nikita-bhatia
Copy link
Contributor

What this PR does / why we need it:
While doing Portworx uninstall, all the components are deleted and for Plugin, even though plugin is not created on non-openshift clusters, operator tries to delete it.

  • As a fix, added additional check to check if plugin is supported on the platform or not.

Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PWX-38400

Special notes for your reviewer:

  • Existing UT TestPluginInstallAndUninstall verifies the test of uninstall on OCP platform
  • Manually verified on vanilla k8s and OCP platform install and uninstall of PX.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (30ed9ab) to head (c7a3ccf).

Files Patch % Lines
drivers/storage/portworx/component/plugin.go 20.00% 8 Missing and 8 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-24.2.0    #1655      +/-   ##
==================================================
- Coverage           79.79%   78.29%   -1.50%     
==================================================
  Files                  61       61              
  Lines               18831    18833       +2     
==================================================
- Hits                15026    14746     -280     
- Misses               2715     3005     +290     
+ Partials             1090     1082       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been in review for 3 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant