-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using certificates for Azure Key vault. #81
Comments
I'm from the Rook team. |
@sp98 Yes feel free to send out a PR and we will review it. cc @dahuang-purestorage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST
What happened:
As of now, the azure key vault client can be created using the ClientID and ClientSecret. The recommended way of creating the client is using a certificate.
What you expected to happen:
Create azure key vault client using certificate. Use the
NewServicePrincipalTokenFromCertificate
function to generate the token using certificate.How to reproduce it (as minimally and precisely as possible):
N/A
Anything else we need to know?:
N/A
Environment:
uname -a
):The text was updated successfully, but these errors were encountered: