Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LastQueriedAt older than LastUsefulAt #613

Open
Stebalien opened this issue Apr 27, 2020 · 4 comments
Open

LastQueriedAt older than LastUsefulAt #613

Stebalien opened this issue Apr 27, 2020 · 4 comments
Assignees
@aarshkshah1992
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

I've noticed that LastQueriedAt can be older than LastUsefulAt. I think we're failing to track LastQueriedAt in some cases.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 27, 2020
@aarshkshah1992 aarshkshah1992 self-assigned this Apr 27, 2020
@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Apr 27, 2020 •
edited
Loading

@Stebalien

LastQueriedAt can be older than LastUsefulAt . We update LastQueried at as soon as we "successfully" query a peer i.e. we don't see any errors after the query RPC.

However, we update LastUsefulAt at the end of the lookup once all queries/query RPCs are complete.
So, LastUsefulAt is updated for all peers together, but AFTER LastQueriedAt is updated during the individual queries.

I'm not sure if this is a bug at all. The relative ordering between LastQueriedAt and LastUsefulAt isn't used to determine anything.

@Stebalien
Copy link
Member Author

Hm. Then we have some very long running queries. I'm seeing queryies where "last useful" is 4 minutes ago and "last queried" is 20 minutes ago.

@Stebalien
Copy link
Member Author

This was on a "lan" DHT so I don't think long queries was the issue.

@aarshkshah1992
Copy link
Contributor

I'll dig deeper.

@iand iand mentioned this issue Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarshkshah1992 aarshkshah1992

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @aarshkshah1992