Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

close all UDP connections when the reuse is closed #216

Merged
merged 2 commits into from
Jul 23, 2021
Merged

close all UDP connections when the reuse is closed #216

merged 2 commits into from
Jul 23, 2021

Conversation

marten-seemann
Copy link
Collaborator

Fixes #215.

Stebalien
Stebalien approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd GC from a defer in gc, but either works.

@marten-seemann
Copy link
Collaborator Author

That might be slightly nicer, don't really have an opinion in either direction. Updated the PR.

@marten-seemann marten-seemann merged commit 43f4c9d into master Jul 23, 2021
@Stebalien Stebalien deleted the close-conns-on-reuse-close branch July 23, 2021 16:24
@Stebalien Stebalien mentioned this pull request Jul 26, 2021
Closed
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dangling sockets
2 participants
@marten-seemann @Stebalien