This repository has been archived by the owner on May 26, 2022. It is now read-only.
improve timeouts #77
Merged
improve timeouts #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Jun 14, 2018
magik6k
approved these changes
Jun 15, 2018
|
[well, assuming tests pass after importing gx deps] |
Stebalien
added
the
status/blocked
The global per-peer dial timeout had a significant drawback: When dialing many peers, this timeout could cause libp2p to cancel dials while they were still stuck in the limiter. A better but more complicated approach is a time budget system but we can implement that later. This change simply applies the limit to each `DialPeer`/`NewStream` call independently and makes it easy to override. While old timeout tried to account for how much we're willing to spend dialing a single peer, this new timeout tries to account for the amount of time a single "client" is willing to wait for a dial to complete before they no longer care.
Stebalien
force-pushed
the
feat/better-timeouts
branch
from
ecef7be
to
8071fe6
Compare
Stebalien
removed
the
status/blocked
|
So, this is now done. IMO, it's a strict improvement so we might as well merge and continue discussing improvements in libp2p/go-libp2p#1547. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #70, libp2p/go-libp2p#1547
Depends on libp2p/go-libp2p-net#26
(needs gx deps to be bubbled)