Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHT: go-libp2p v0.34 breaks TestRTEvictionOnFailedQuery in the DHT #2911

Closed
Stebalien opened this issue Aug 6, 2024 · 4 comments · Fixed by #2916
Closed

DHT: go-libp2p v0.34 breaks TestRTEvictionOnFailedQuery in the DHT #2911

Stebalien opened this issue Aug 6, 2024 · 4 comments · Fixed by #2916

Comments

@Stebalien
Copy link
Member

To reproduce, download go-libp2p-kad-dht and run:

go test -run TestRTEvictionOnFailedQuery

See: libp2p/go-libp2p-kad-dht#974

Note: That PR updates a bunch of deps, but I've narrowed it down to libp2p v0.33 to v0.34.
@Stebalien Stebalien mentioned this issue Aug 6, 2024
Open
@sukunrt
Copy link
Member

sukunrt commented Aug 9, 2024

Based on this: libp2p/go-libp2p-kad-dht#974 (comment)
This should be fixed in go-libp2p-kad-dht. Closing a custom constructed basic host should not close the swarm as the host didn't create the swarm.

@Stebalien
Copy link
Member Author

I'm confused. Connect should fail after closing the host.

@Stebalien
Copy link
Member Author

Oh.... I see. Although I disagree, giving a swarm to a host transfers ownership.

@sukunrt
Copy link
Member

sukunrt commented Aug 9, 2024

You're right.

host.Connect should fail after closing the host

@sukunrt sukunrt mentioned this issue Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

basic_host: close swarm on Close libp2p/go-libp2p
2 participants
@Stebalien @sukunrt