add an option to start the relay v2 #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
marten-seemann
force-pushed
the
use-relayv2
branch
2 times, most recently
from
71eb4bf
to
f6460f9
Compare
vyzo
reviewed
Sep 23, 2021
|
|
marten-seemann
force-pushed
the
use-relayv2
branch
2 times, most recently
from
e101c65
to
97696ac
Compare
vyzo
reviewed
Sep 24, 2021
There was a problem hiding this comment.
LGTM; only thing we need is to make it disabled by default as @Stebalien requested.
Also, the package name for the manager/service is rather confusing, let's call it something more appropriate.
config/config.go
Outdated
| Relay bool | ||
| Relay bool // should the relay transport be used | ||
|
|
||
| DisableRelayService bool // should we run a circuitv2 relay (if publicly reachable) |
There was a problem hiding this comment.
let's heed to @Stebalien's request to not enable it by default, so this should be EnableRelayService I guess and the logic inverted.
There was a problem hiding this comment.
Makes sense.
We'll still enable this by default in IPFS / Filecoin, won't we?
There was a problem hiding this comment.
We'll still enable this by default in IPFS / Filecoin, won't we?
Yes, or at least in IPFS. But libp2p is a library not an application.
marten-seemann
force-pushed
the
use-relayv2
branch
from
97696ac
to
73d295d
Compare
marten-seemann
changed the title
marten-seemann
force-pushed
the
use-relayv2
branch
from
73d295d
to
bec5b2b
Compare
marten-seemann
changed the title
marten-seemann
force-pushed
the
use-relayv2
branch
2 times, most recently
from
3c26307
to
70e17db
Compare
marten-seemann
force-pushed
the
use-relayv2
branch
from
70e17db
to
0aeef55
Compare
vyzo
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not satisfied with the names for the config options, but I struggle to come up with something better. Suggestions would be highly appreciated.
I wish we could use
EnableRelay()here, but unfortunately this is already taken to enable the relay transport.