Perf protocol #2161
Closed
Perf protocol #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| } | ||
|
|
||
| func (ps *PerfService) sendBytes(ctx context.Context, s network.Stream, bytesToSend uint64, buf []byte) error { |
There was a problem hiding this comment.
Easier to read if you allocate buf in this function.
There was a problem hiding this comment.
You then have to allocate the buf twice in the send and drain paths. Yes, I know this is a pool, but you still do the put and get work.
| func (ps *PerfService) drainStream(ctx context.Context, s network.Stream, buf []byte) (uint64, error) { | ||
| var recvd uint64 | ||
| for { | ||
| n, err := s.Read(buf) |
There was a problem hiding this comment.
You can copy into io.Discard.
26 tasks
|
With libp2p/test-plans#184 merged, we now have a libp2p-perf protocol implementation on top of go-libp2p in |
|
Was about to come in and ask the same, I believe this can be closed. Please re-open if it shouldn't be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements libp2p/specs#478