Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuitv2: improve voucher validation #2826

Merged
merged 2 commits into from
Jun 12, 2024
Merged

circuitv2: improve voucher validation #2826

merged 2 commits into from
Jun 12, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jun 7, 2024

No description provided.

@sukunrt sukunrt requested a review from MarcoPolo June 7, 2024 08:47
if h.ID() != voucher.Peer {
return nil, ReservationError{
Status: pbv2.Status_MALFORMED_MESSAGE,
Reason: fmt.Sprintf("invalid voucher peer id: expected %s, got %s", signerPeerID, voucher.Peer),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is wrong. should be expected h.ID() go voucher.Peer

@sukunrt sukunrt requested a review from MarcoPolo June 10, 2024 10:10
@sukunrt sukunrt merged commit 1be87de into master Jun 12, 2024
11 checks passed
sukunrt added a commit that referenced this pull request Jun 12, 2024
sukunrt added a commit that referenced this pull request Jun 12, 2024
MarcoPolo added a commit that referenced this pull request Jun 12, 2024
* identify: Don't filter addr if remote is neither public nor private (#2820)

Updates the filterAddrs logic to no-op if the address is neither public nor private.

This fixes an issue in mocknet that assigns each node an address in the IPv6 discard prefix space. That doesn't interact well with this logic in identify.

The issue mocknet hits is that it filters out all received listen addresses and then doesn't remember any address for the peer.

* identify: fix bug in observed address handling (#2825)

* identify: add test for observed address handling (#2828)

This modifies TestObservedAddrManager to verify the fix in #2825

* libp2phttp: workaround for ResponseWriter's CloseNotifier (#2821)

* libp2phttp: workaround for CloseNotifier

* Add lintignore

* circuitv2: improve voucher validation (#2826)

* webrtc: fix ufrag prefix for dialing (#2832)

* webrtc: add a test for establishing many connections (#2801)

Update pion/ice to include the fix for out of order 
ConnectionState update callbacks

* release v0.35.1

---------

Co-authored-by: Marco Munizaga <[email protected]>
Co-authored-by: Ivan Shvedunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants