Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update webrtc dep for fix build issue in android #3001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ja7ad
Copy link

@Ja7ad Ja7ad commented Oct 9, 2024

When build android version got error undefined for package anet.

# command-line-arguments
./main.go:10:17: undefined: anet.Interfaces

Currently without issue build in anet v0.0.5 and support go 1.23.

GOOS=android GOARCH=arm64 go build -ldflags "-s -w -checklinkname=0" main.go 

Fixes #2997

@p-shahi p-shahi requested a review from sukunrt October 9, 2024 21:22
@sukunrt
Copy link
Member

sukunrt commented Oct 10, 2024

We will update all the deps before the next release.

@sukunrt sukunrt closed this Oct 10, 2024
@MarcoPolo
Copy link
Collaborator

I asked for this update since it’s specific to the Android build and wanted them to check what actually needed to be updated.

We will still update deps in the next release, but it’s good to know what fixes their issue.

@MarcoPolo MarcoPolo reopened this Oct 10, 2024
@MarcoPolo
Copy link
Collaborator

Can you confirm if this solves your issue? (my guess is no, but I want to check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue build android version
3 participants