Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circuitv2: sanitize address inputs: check address peer id when returning a reservation message #3006

Open
wants to merge 1 commit into
base: marco/impl-resolver-circuit-tpt
Choose a base branch
from
Open

fix: circuitv2: sanitize address inputs: check address peer id when returning a reservation message #3006

wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link
Collaborator

closes #3003

sukunrt
sukunrt approved these changes Oct 11, 2024
View reviewed changes
p2p/protocol/circuitv2/relay/relay.go
var addrBytes [][]byte
for _, addr := range r.host.Addrs() {
for _, addr := range selfAddrs {
if !manet.IsPublicAddr(addr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does host.Addrs return an address with P2P component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoPolo @sukunrt