Key exchange with jsrsasign

[richardschneider]

This uses the jsrsasign package to create password protected private keys.

Currently, it only works with RSA key types.

See issue #114

PR libp2p/js-libp2p-keychain#18 is dependent upon this PR

[richardschneider]

@diasdavid Could you help me fix the circle CI build, see https://circleci.com/gh/libp2p/js-libp2p-crypto/296?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[daviddias]

Can you put these in files as text data?

[richardschneider]

Sure can, but why? They are only used in one place.

[richardschneider]

Do you want me to use fs to read the file. Or wrap them in module.export with back tick and then require them.

[daviddias]

You can have a file with these pem keys and do fs.readFileSync once.

[richardschneider]

Yes, I can do. But why. Tests should be easy to read. Why the indirection and requiring file support.

Will fs.readFileSync be supported in browser tests?

[daviddias]

@richardschneider fs.readFileSync is supported (thanks to the bundler).

Tests should be easy to read.

Agreed and that is why having 40 lines of a string that has no other information that is human readable than the fact that it is a private key is better kept in a file that has that name so that in the test code you just have one line to refer to the private key.

[daviddias]

If you feel really strongly about leaving them here, we can deal with it. It might just be my personal preference. No need for bikeshedding :)

[daviddias]

@victorbjelkholm Circle is having issues again? It would be great if you could create a doc on explaining why these issues happen and what you do to fix them.

[victorb]

@diasdavid sure, I can add a document about it, where you want me to add it?

TLDR is that if you see NSS >= 3.26 is required errors when running browser tests, you'll need to upgrade the build environments Ubuntu version from 12.04 to 14.04, and then do a push again to the same branch. The setting can be found here for this repository: https://circleci.com/gh/libp2p/js-libp2p-crypto/edit#build-environment

[daviddias]

thanks @victorbjelkholm ! just updated it :)

Is there any repo to track CI stuff? I feel that info belongs there, even if just in a issue for now.

[victorb]

@diasdavid perfect! I created a issue in ipfs/ci-sync (which holds bunch of scripts for CI-related things) for now, here: ipfs-inactive/ci-sync#3 Eventually, that repository will be folded into ipfs/jenkins to create a new ipfs/ci repository where we can keep everything.

[daviddias]

Overall LGTM. One last request. @richardschneider mind checking the new bundle size vs the previous one? Run npm run build to get it.

[richardschneider]

@diasdavid npm run build fails on my windows machine. PS: thanks for getting Circle CI to work.

> [email protected] build C:\Users\Owner\Documents\GitHub\js-libp2p-crypto
> aegir build

 √ Clean ./dist
 × Webpack Build
   →    Please use output.path to specify absolute path and output.filename for the file name.
   Minify
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.output.filename: A relative path is expected. However the provided value "C:\\Users\\Owner\\Documents\\GitHub\\js-libp2p-crypto\\src\\index.js" is an absolute path!
   -> Specifies the name of each output file on disk. You must **not** specify an absolute path here! The `output.path` option determines the location on disk the files are written to, filename is used solely for naming the individual files.
   Please use output.path to specify absolute path and output.filename for the file name.
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.output.filename: A relative path is expected. However the provided value "C:\\Users\\Owner\\Documents\\GitHub\\js-libp2p-crypto\\src\\index.js" is an absolute path!
   -> Specifies the name of each output file on disk. You must **not** specify an absolute path here! The `output.path` option determines the location on disk the files are written to, filename is used solely for naming the individual files.
   Please use output.path to specify absolute path and output.filename for the file name.
    at webpack (C:\Users\Owner\Documents\GitHub\js-libp2p-crypto\node_modules\webpack\lib\webpack.js:19:9)
    at P (C:\Users\Owner\Documents\GitHub\js-libp2p-crypto\node_modules\pify\index.js:49:6)
    at new Promise (<anonymous>)
    at C:\Users\Owner\Documents\GitHub\js-libp2p-crypto\node_modules\pify\index.js:11:9
    at ret (C:\Users\Owner\Documents\GitHub\js-libp2p-crypto\node_modules\pify\index.js:72:32)
    at config.then (C:\Users\Owner\Documents\GitHub\js-libp2p-crypto\node_modules\aegir\src\build\browser.js:17:25)
    at <anonymous>

[richardschneider]

@diasdavid RTM. Provides all the primitives required by keychain to implement ipfs key.

[daviddias]

@richardschneider Did you manage to get npm run build to run? Can I get that bundle size comparison?

[richardschneider]

@diasdavid No,, did not get build working. Can you do it.

[richardschneider]

@diasdavid https://unpkg.com/[email protected]/lib/ reports that the package is 259 kB