feat/start and stop #15
Conversation
|
@gavinmcdermott could you accept the invitation for the libp2p org? |
| * @returns {undefined} | ||
| * | ||
| */ | ||
| start (callback) { |
There was a problem hiding this comment.
remembering the discussions for the better js-ipfs start and stop interface, could we make this callback just bind to a start event and similarly for stop?
There was a problem hiding this comment.
I believe the improving init -- ipfs/js-ipfs#556 -- discussion comes from the annoyance of having 3 steps to start js-ipfs (init, load, goOnline), while in bitswap, floodsub, libp2p it is really just one
|
|
||
| setImmediate(() => { | ||
| this.started = true | ||
| callback() |
There was a problem hiding this comment.
why a callback at all if this is actually snyc?
There was a problem hiding this comment.
mostly future proofing, but I was also asking myself if we should wait for the dials to happen.
|
@diasdavid - thanks for the ping—just accepted. Even though I've been a bit IDEO-work-focused this week, I've been tracking your guys' progress via the latest PRs—beautiful! I'm almost wrapped up getting the latest version of Nomad ready for a 2 week intensive build/exploration. In a nutshell, by this weekend:
We'll get a bunch of mileage out of the latest updates next week (meaning pubsub should be getting hammered on)...so I'm sure useful new questions will begin to surface. Look forward to being back in the loop; talk soon! |
Needed to finish ipfs/js-ipfs#644