Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

feat: improve circuit err messages #250

Merged
merged 3 commits into from
May 1, 2018
Merged

feat: improve circuit err messages #250

merged 3 commits into from
May 1, 2018

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Apr 12, 2018

adding better error handling and clear error messages

@ghost ghost assigned dryajov Apr 12, 2018
@ghost ghost added the in progress label Apr 12, 2018
@coveralls
Copy link

coveralls commented Apr 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 834

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 87.958%
Files with Coverage Reduction New Missed Lines %
../src/dial.js 7 88.82%
Totals Coverage Status
Change from base Build 831: 0.3%
Covered Lines: 541
Relevant Lines: 588
💛 - Coveralls

@dryajov dryajov mentioned this pull request Apr 16, 2018
Closed
daviddias
daviddias approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dryajov

@ghost ghost assigned daviddias May 1, 2018
@daviddias daviddias merged commit 63ad87a into master May 1, 2018
@daviddias daviddias deleted the feat/circuit-err branch May 1, 2018 13:26
@ghost ghost removed the in progress label May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@dryajov dryajov

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dryajov @coveralls @daviddias