This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: ignore dial request when one is in progress #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the instance that multiple dials are requested for the same connection, this will ignore subsequent dials. In the future, we should revisit this logic for coalescing dials (a successful request with dials in the queue) and backoffs (a failure with dials in the queue). There is a limit dialer at the transport level, but we don't currently handle it at the connection level.
This issue was exposed when testing the libp2p 0.24.0-rc.1 candidate release against the js-ipfs tests.