This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: identify on dial #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously identify was only run by the receiver. this change is inline with how go operates
ghost
assigned fix: ensure incomming conns disconnect properly
jacobheun
force-pushed
the
fix/identify-dial
branch
from
7e01463
to
fbf6753
Compare
1 task
vasco-santos
approved these changes
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously identify was only run by the receiver. This change is inline with how go operates.
Required by libp2p/js-libp2p-daemon#14