This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
WIP - Feat/circuit interop #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
force-pushed
the
feat/circuit-interop
branch
from
ea0dfc1
to
b9bdb79
Compare
53 tasks
dryajov
requested review from
whyrusleeping and
dignifiedquire
and removed request for
a team
9 tasks
daviddias
approved these changes
Aug 30, 2017
daviddias
suggested changes
Aug 30, 2017
9 tasks
dryajov
force-pushed
the
feat/circuit-interop
branch
from
e750161
to
5652591
Compare
daviddias
suggested changes
Sep 14, 2017
src/index.js
Outdated
| @@ -68,9 +67,6 @@ class TCP { | |||
| multiaddrs = [multiaddrs] | |||
| } | |||
| return multiaddrs.filter((ma) => { | |||
| if (includes(ma.protoNames(), 'ipfs')) { | |||
| ma = ma.decapsulate('ipfs') | |||
| } | |||
| return mafmt.TCP.matches(ma) | |||
There was a problem hiding this comment.
Notes from the call today:
It should continue to be valid to pass an ipfs multiaddr, it just needs to check things differently.
-
- check if it is relay, if it is, skip it
-
- if not relay, check if it is ipfs, if it is, decapsulate
-
- check if it is TCP, if it is, include it
There was a problem hiding this comment.
@diasdavid ii and iii already happen in master, so it should be adding a check for circuit and skipping it if its present (i).
dryajov
force-pushed
the
feat/circuit-interop
branch
from
f321927
to
23a7cbe
Compare
daviddias
approved these changes
Oct 13, 2017
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on mafmt PR - multiformats/js-mafmt#16