Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegated Routing #120

Closed
4 tasks done
daviddias opened this issue Sep 4, 2017 · 15 comments
Closed
4 tasks done

Delegated Routing #120

daviddias opened this issue Sep 4, 2017 · 15 comments
Assignees
Labels
exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

daviddias commented Sep 4, 2017

Following ipfs/team-mgmt#492

Tasks:

@daviddias
Copy link
Member Author

@lgierth any update on the first task of the list?

@daviddias daviddias added exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up labels Nov 6, 2017
@daviddias
Copy link
Member Author

@lgierth mind updating this issue with what we discussed and the latest developments? Thank you!

@ghost
Copy link

ghost commented Jan 23, 2018

Here are my notes:

  • expose dht/findpeer, dht/findprovs, swarm/connect, refs commands
  • implement dht/putpeer command
  • issue for "awesome delegated routing" endeavour
  • update libp2p interfaces: peer-routing and content-routing
  • comment on js-ipfs relay plans
    • announce /p2p-circuit addrs
    • configure static list of ~20 well-known relay nodes, pick 2
  • debug /wss connection death bug
    • check out js-ipfs bootstrapper tests

@daviddias daviddias added the status/ready Ready to be worked label Feb 5, 2018
@daviddias
Copy link
Member Author

A couple more notes.

The Peer Routing flows will use the findPeer call directly. While the Content Routing flow will be:

  • for providing:
    • Ask the delegated peer to fetch the content
    • Ask the delegated peer to become a provider (which happens by fetching the content in the first place)
  • for finding providers
    • Ask the delegated peer to tell us who is providing
    • Ask the delegated peer to fetch that data
    • Fetch the data from the delegated peer.

@RangerMauve
Copy link

Where are the specs for this functionality?

@dignifiedquire
Copy link
Member

Implementations are being done here:

@daviddias daviddias changed the title Delegated Routing Module Delegated Routing Jun 4, 2018
@daviddias daviddias added P0 Critical: Tackled by core team ASAP and removed P1 High: Likely tackled by core team if no one steps up labels Jun 4, 2018
@jacobheun
Copy link
Contributor

Both libp2p/js-libp2p-delegated-peer-routing and libp2p/js-libp2p-delegated-content-routing are about ready for release. I've got a local branch I am working on to integrate those into libp2p. The biggest issue right now is that https://ipfs.io is not working for those two.

I will make sure the local tests aren't hitting external endpoints, but the default peer and content routing won't work until ipfs.io is fixed.

I'll make sure the endpoint is configurable. Do we have any expected eta on a fix or separate url for the ipfs.io delegate?

@ghost
Copy link

ghost commented Jul 26, 2018

The biggest issue right now is that https://ipfs.io is not working for those two.

Ah yeah, there's a branch that needs merging. I'll be on it once the urgent DWeb Summit tasks are done.

@daviddias
Copy link
Member Author

@jacobheun this is shipped, right?

@jacobheun
Copy link
Contributor

@diasdavid this will ship with 0.24. The go-ipfs work is still not complete, but our support will be there in the next release.

@daviddias
Copy link
Member Author

@jacobheun what's the go-ipfs work? @Stebalien can you help with this?

@jacobheun
Copy link
Contributor

The outstanding PR in go-ipfs is ipfs/kubo#5565.
Once that is release we can get infra to deploy, ipfs/infra#426.

@vasco-santos
Copy link
Member

This is done

@daviddias
Copy link
Member Author

@vasco-santos is it tested, deployed and monitored?

@vasco-santos
Copy link
Member

It is implemented, tested and deployed afaik (ipfs/js-ipfs/ipfs#configuring-delegate-routers).

Anyway, the scope of this issue seems to be the implementation on js-libp2p, which is released and tested. I suggest that we start to create more scoped issues, otherwise there is no visibility on what is done and what is expected from the issue. I am going through the issues on js-libp2p and there are several issues on this situation.

If we want to have this service monitored, it should live under its specific issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

5 participants