-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubts / questions regarding upstreaming debug panel changes #1764
Comments
You can create the repo and keep it in your own organization. Feel free name it whatever.
Our inclination is to not bundle this with the js-libp2p framework, it can be part of a module that you expose.
Suggestion is to publish a new impl of inteface-metrics that uses promjs instead.
This can be added to your promjs impl of interface-metrics
post 0.45.0 you can add a new service as a custom protocol
This is better kept in the application space, we don't want to add this property to PeerId |
@prathamesh0 did this help? |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
This issue was closed because it is missing author input. |
Here are a few questions that will help us with upstreaming the debug panel changes:
react-libp2p-debug
: holds all the React componentslibp2p-util
: holds some util code that will eventually get upstreamed to js-libp2pexample-libp2p-app
: an example app that uses the debug panellibp2p-util
package mentioned above; but can be integrated upstream behind a config optionlibp2p/js-libp2p
?libp2p/js-libp2p-prometheus-metrics
:prom-client
does not support browser environments; in the fork we are usingpromjs
for getting the metrics in browser; is it fine to switch topromjs
as a client library?Metrics
interface (@libp2p/interface-metrics
) that allow users to access metrics without keeping a reference to some global singleton / metrics instance?Metrics
interface to get data as JSON (instead of string) will also help in debug panel as we won't have to parse the string result on the UI sidedebug
protocol implementation for network graphlibp2p/js-libp2p
that nodes can enable with a config optionunique-names-generator
) to make the displayed peer ids more human readablelibp2p/js-libp2p
? Can it be added as an additional property in thePeerId
type / interface?The text was updated successfully, but these errors were encountered: