Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose Metrics for Websockets #1915

Closed
Tracked by #2664
maschad opened this issue Jul 31, 2023 · 2 comments · Fixed by #2649
Closed
Tracked by #2664

feat: Expose Metrics for Websockets #1915

maschad opened this issue Jul 31, 2023 · 2 comments · Fixed by #2649
Assignees
@SgtPooki
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature

Comments

@maschad
Copy link
Member

maschad commented Jul 31, 2023 •
edited
Loading

Done Criteria

Export metrics leveraging the work done in #1458

Motivation

Better observability for performance and benchmarking. See: #1458 (comment)

Originally libp2p/js-libp2p-websockets#197
@maschad maschad added the need/triage Needs initial labeling and prioritization label Jul 31, 2023
@maschad maschad self-assigned this Jul 31, 2023
@maschad maschad added kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Jul 31, 2023
@p-shahi p-shahi added help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Aug 8, 2023
@maschad maschad removed their assignment Aug 14, 2023
@achingbrain achingbrain removed the P2 Medium: Good to have, but can wait until someone steps up label May 14, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Aug 5, 2024

@achingbrain @maschad anyone working on this one? we will likely want to enable this so we can get visibility into websocket performance for https:/libp2p/js-libp2p-amino-dht-bootstrapper

@SgtPooki SgtPooki mentioned this issue Aug 5, 2024
Merged
11 tasks
@maschad
Copy link
Member Author

maschad commented Aug 5, 2024

Not to my knowledge @SgtPooki , feel free to take it on!

@SgtPooki SgtPooki self-assigned this Aug 5, 2024
@SgtPooki SgtPooki mentioned this issue Aug 14, 2024
Open
1 task
@SgtPooki SgtPooki removed the help wanted Seeking public contribution on this issue label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add WebSockets metrics libp2p/js-libp2p
4 participants
@achingbrain @SgtPooki @maschad @p-shahi