WebRTC SDP handshake connection transient?

[marcus-pousette]

• Version:
  @libp2p/webrtc 4.1.3

• Subsystem:
  WebRTC

Severity:

Medium

Description:

I continue my investigation from #2646 and found that there is a bunch of connection and disconnection events that goes through the protocol handler due to the temporary WebRTC SDP handshake connection.

js-libp2p/packages/transport-webrtc/src/private-to-private/initiate-connection.ts

Line 57 in 944935f

connection = await transportManager.dial(baseAddr, {

When shouldCloseConnection is true, I would want to handle this connection as transient since it might close very soon after open.

Doing a

connection.transient = true

line after the dial does not however fix the problem completely since we still have the problem that all transient connection close events go through the protocol handler topology changes even if notifyOnTransient: false, which is another issue #2369