Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure WebSockets #931

Closed
D4nte opened this issue Apr 28, 2021 · 1 comment
Closed

Secure WebSockets #931

D4nte opened this issue Apr 28, 2021 · 1 comment
Labels
need/analysis Needs further analysis before proceeding

Comments

@D4nte
Copy link
Contributor

D4nte commented Apr 28, 2021

Type: Bug/Question

Severity: High

Description: Secure WebSockets does not seem to work

Steps to reproduce the error:

See #930 for the code reproducing the issue.

When trying to setup secure websockets after following the libp2p-websockets test setup: https:/libp2p/js-libp2p-websockets/blob/e9291044a731ee7ba83455b134c3141182073e4f/test/node.js#L296

I am getting the following error:

> npm run test ./transports

4.js
node 1 is listening on:
/ip4/127.0.0.1/tcp/10000/ws/p2p/QmTSzDAPTJRqgkG8P6BAhHPvhnbiCRgjf47TPxrgow6PrX
node 2 is listening on:
/home/froyer/src/libp2p/js-libp2p/node_modules/p-some/index.js:31
                        reject(new AggregateError(errors));
                               ^

AggregateError: 
    Error: socket hang up
        at Array.map (<anonymous>)
        at maybeSettle (/home/froyer/src/libp2p/js-libp2p/node_modules/p-some/index.js:31:11)
        at /home/froyer/src/libp2p/js-libp2p/node_modules/p-some/index.js:69:23
        at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at maybeSettle (/home/froyer/src/libp2p/js-libp2p/node_modules/p-some/index.js:31:11)
    at /home/froyer/src/libp2p/js-libp2p/node_modules/p-some/index.js:69:23
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

@vasco-santos vasco-santos added the need/triage Needs initial labeling and prioritization label Apr 28, 2021
@BigLep BigLep added need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels May 3, 2021
@BigLep
Copy link
Contributor

BigLep commented May 3, 2021

Thanks for letting know. We'll followup in #930

@BigLep BigLep closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/analysis Needs further analysis before proceeding
Projects
None yet
Development

No branches or pull requests

3 participants