Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS spec doesn't mention ALPN libp2p used by implementations #607

Open
Jorropo opened this issue Mar 16, 2024 · 1 comment
Open

TLS spec doesn't mention ALPN libp2p used by implementations #607

Jorropo opened this issue Mar 16, 2024 · 1 comment

Comments

@Jorropo
Copy link

Jorropo commented Mar 16, 2024

See https://grep.app/search?q=alpn&filter[repo.pattern][0]=libp2p.
Implementations use the libp2p ALPN which allows to route TLS streams to libp2p and non libp2p connections on the same listener (or libp2p over quic vs libp2p over webtransport for quic).

I don't know if current implementations can handle arbitrary ALPNs and this is just a nice to have client sends or if it's actually required for it to function.

A quick CTRL + F ALPN in https:/libp2p/specs/blob/master/tls/tls.md yields no results.
Same for looking at all the occurrences of the libp2p string in the same file.

@MarcoPolo
Copy link
Contributor

I'm pretty sure it's required. You're right, it should be documented in tls.md. It is documented in our quic spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants