-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake test fails with strict diagnostic options for Intel compilers #193
Comments
Hi Alexis @amontoison, Could you have a look at this? Thank you. Best regards, |
Hi @zaikunzhang! More details: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54817 |
Thank you @amontoison . Could you propose the changes by a PR? There are also other warnings/ errors of different nature. Many thanks. |
Hi @nbelakovski ,
I tried adding strict diagnostic options for Intel compilers to cmake.yml:
https:/libprima/prima/compare/5366ab6..ea93390
After that, a few warnings are emitted, which are treated as errors, and the CMake test then fails:
https:/libprima/prima/actions/runs/8790876683
Would you have time to have a look?
I would like to reiterate the following.
Warnings are future bugs. PRIMA does not tolerate warnings, unless they are emitted due to compiler bugs or we are one thousand percent sure that they are irrelevant.
In our development and test, compilers and linters should be invoked with the most strict diagnostic/debugging options, e.g.,
-Wall -Wextra -Wpedantic -Werror
or something similar. This also applies to other code such as C++ and Python.Thank you very much.
Zaikun
The text was updated successfully, but these errors were encountered: