Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added clang-cl build to CI #631

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Added clang-cl build to CI #631

merged 2 commits into from
Oct 26, 2023

Conversation

JoergAtGithub
Copy link
Contributor

@JoergAtGithub JoergAtGithub commented Oct 22, 2023 •
edited
Loading

  • Using -G"NMake Makefiles", because I couldn't get the other generators to work with clang-cl
  • ASAN=off because it's not supported by clang-cl yet

Please note, that the MinGW fail already occured with the last commit on the master branch and is unrelated to this PR.

Youw
Youw approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Youw Youw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting this doesn't catch the #630
But it is good to have such variation of the build checked by CI anyway, thanks.

@Youw
Copy link
Member

Youw commented Oct 23, 2023

BTE: the MinGW failure - there is a valid issue in the code, as per log.
Would be great to handle that too (separately of course).

@JoergAtGithub
Copy link
Contributor Author

Interesting this doesn't catch the #630

This replaces only the compiler, but not the C runtime. I guess only the clang CRT shows these issues.

@mcuee mcuee added the build system/CI Anything related to building the project or running on CI label Oct 23, 2023
Youw
Youw reviewed Oct 26, 2023
View reviewed changes
.github/workflows/builds.yml Outdated Show resolved Hide resolved
@Youw Youw merged commit 3c04eac into libusb:master Oct 26, 2023
13 of 14 checks passed
@JoergAtGithub JoergAtGithub deleted the ClangCL branch October 27, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youw Youw Youw approved these changes

Assignees
No one assigned
Labels
build system/CI Anything related to building the project or running on CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoergAtGithub @Youw @mcuee