Skip to content

Commit

Permalink
fix link failure with libtiff
Browse files Browse the repository at this point in the history
The fuzz targets were failing to link with:

```
Step google#4: /work/lib/libtiff.a(tif_lzma.o): In function `TIFFInitLZMA':
Step google#4: /src/libtiff/libtiff/tif_lzma.c:465: undefined reference to
`lzma_lzma_preset'
```

It looks like it's become necessary to explicitly link -llzma, see:

https://gitlab.com/libtiff/libtiff/commit/4159bda6db2f8cf8e848d8095b5d37d49ba67a10

oss-fuzz issue:

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18928#c4

Thanks to @lovell.
  • Loading branch information
jcupitt committed Nov 20, 2019
1 parent 78e191e commit 8bce5ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion projects/libvips/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ for fuzzer in fuzz/*_fuzzer.cc; do
$WORK/lib/libtiff.a \
$LIB_FUZZING_ENGINE \
-Wl,-Bstatic \
-lfftw3 -lgmodule-2.0 -lgobject-2.0 -lffi -lglib-2.0 -lpcre -lexpat \
-lfftw3 -lgmodule-2.0 -lgobject-2.0 -lffi -lglib-2.0 -lpcre -lexpat -llzma \
-Wl,-Bdynamic -pthread
ln -sf "seed_corpus.zip" "$OUT/${target}_seed_corpus.zip"
done
Expand Down

0 comments on commit 8bce5ae

Please sign in to comment.