Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving colors for color blind people (issue lichess-org/lila#10410) #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rabergsel
Copy link

@Rabergsel Rabergsel commented Jun 9, 2022

Issue lichess-org/lila#10410 : Colorblind people cant see the difference between red and green.

Making higher contrast in color brushes so colorblind people can at least see different shades of red and green, and
deuteronopia people (blue-green) now should see different shades too, because of making contrast of green and blue higher.

I didn't change the colors in total, I only varied them to make the contrast higher (and for me they still look good).

Making higher contrast in color brushes so colorblind people can at least see different shades of red and green, and
deuteronopia people (blue-green) now should see different shades too, because of making contrast of green and blue higher.
@benediktwerner
Copy link
Member

benediktwerner commented Jun 9, 2022

Could you post a screenshot of how it looks?

Also, you can link to an issue from another repo using lichess-org/lila#10410

And ideally, the PR title should still independently explain what your doing (not just "fix issue 13234") and same goes for the commit title ("update state.ts").

@Rabergsel
Copy link
Author

Rabergsel commented Jun 9, 2022

lichess_normal_vision
lichess_protanopia

I added a normal vision representation and a protanopia (red-green colorblindesss) filter simulation of the analysis board.

Maybe it should be mentioned that the colours were chosen by color replacing.

@Rabergsel Rabergsel changed the title Targeting issue lila/#10410 Improving colors for color blind people (issue lichess-org/lila#10410) Jun 9, 2022
@Rabergsel
Copy link
Author

After about one year....
I just saw that this pull request still exists :)
Is this gonna be merged or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants