Refactor unique method to use exists without empty string #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravetii
force-pushed
the
refactor-unique-method
branch
from
b419537
to
63106dc
Compare
|
this is much better, thanks! |
gravetii
commented
Sep 9, 2024
| @@ -32,8 +32,7 @@ extension [A](changes: List[ChangeStreamDocument[A]]) | |||
| def unique: List[ChangeStreamDocument[A]] = | |||
| changes | |||
| .foldRight(List.empty[ChangeStreamDocument[A]] -> Set.empty) { case (change, p @ (acc, ids)) => | |||
| val id = change.docId.getOrElse("") | |||
| if !ids.contains(id) && id != "" | |||
| if change.docId.exists(ids.contains) | |||
There was a problem hiding this comment.
hi @lenguyenthanh this should actually be if change.docId.exists(!ids.contains)
There was a problem hiding this comment.
pushed the patch here - #308
gravetii
added a commit
to gravetii/lila-search
that referenced
this pull request
Sep 9, 2024
Fixes the issue introduced in lichess-org#303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.