Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [BoardEditor] add reset board and starting position option #1035

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sid0-0
Copy link

@sid0-0 sid0-0 commented Sep 17, 2024

Implements #1010

Screenshot:
image

@sid0-0
Copy link
Author

sid0-0 commented Sep 17, 2024

Should I also add an option to Load from FEN?

@sid0-0 sid0-0 force-pushed the issue1010 branch 2 times, most recently from 06ed5f1 to 2047b5c Compare September 19, 2024 12:08
@veloce
Copy link
Contributor

veloce commented Sep 23, 2024

These new buttons should not be placed here, and should not look like a chip. They are action buttons (clear board) where the other ones are toggles on the current position.

We should rearrange as follow imo:

  • add a 'menu' button (menu icon 3 bars as in game screen)
    • flip board, clear board and reset board should be part of this new menu
  • the actual BoardEditorMenu should be renamed BoardEditorPositionSettings
  • the button icon for the position settings should be changed to a 'settings' (cog) icon

@veloce
Copy link
Contributor

veloce commented Sep 23, 2024

Should I also add an option to Load from FEN

We could, but we already have the "Load position" screen which achieves the same.

More interesting is to add the choice picker to choose a preconfigured opening or endgame position like in the website.

@sid0-0
Copy link
Author

sid0-0 commented Sep 23, 2024

Made the suggested changes.
Screenshots:

While we're modifying menu(now settings), I also think we should move the castling options around for better clarity. I would suggest something like this:

More interesting is to add the choice picker to choose a preconfigured opening or endgame position like in the website.

A separate issue is raised for this. I can pick this separately.

@veloce
Copy link
Contributor

veloce commented Sep 24, 2024

I'm not sure about the settings icon on the top nav bar.

I'd expect these settings to be configuration for the board editor itself (like configuring behavior of the editor), and they actually are position related, switches to change the FEN output.

So the button should not be placed on top imo, but I agree that the settings (cog) icon is not a good choice either. Maybe we should just revert to the 'tune' icon and put it back at the bottom. Not entirely satisfied with the tune icon but I cannot find any better one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants