Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Signal GossipQuery support when using IgnoringMessagHandler" #3172

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 12, 2024

Closes #2972.

This reverts commit 843079d which used to fix a small incompatibility with CLN that was fixed with CLN 24.02.2.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (78c0eaa) to head (5a39cc2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3172      +/-   ##
==========================================
- Coverage   89.80%   89.77%   -0.04%     
==========================================
  Files         121      121              
  Lines      100045   100043       -2     
  Branches   100045   100043       -2     
==========================================
- Hits        89845    89809      -36     
- Misses       7533     7558      +25     
- Partials     2667     2676       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valentinewallace
Copy link
Contributor

Do we care to maintain compat with earlier versions of CLN? Doesn't seem harmful to me to keep the prior code

@TheBlueMatt
Copy link
Collaborator

It only impacts nodes that use RGS, so mostly only a mobile issue with LSPs that upgraded quickly to the latest CLN and then didn't upgrade to a point release from a week after. Not sure its worth caring about.

@valentinewallace
Copy link
Contributor

It only impacts nodes that use RGS, so mostly only a mobile issue with LSPs that upgraded quickly to the latest CLN and then didn't upgrade to a point release from a week after. Not sure its worth caring about.

Cool, that makes sense. Landing

@valentinewallace valentinewallace merged commit 3dedbd5 into lightningdevkit:main Jul 15, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert signalling GossipQuery support in IgnoringMessageHandler
4 participants