Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDP basic #215

Open
wants to merge 103 commits into
base: main
Choose a base branch
from
Open

CDP basic #215

wants to merge 103 commits into from

Conversation

francisbouvier
Copy link
Member

No description provided.

@francisbouvier
WIP: CDP
c57bb9e 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Remove alloc from CmdContext struct
babac69 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Free msg at the right place
defab0c 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Working sendLater (I/O timeout)
cfd6fc9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Handle concurrent calls to sendLater
95a64b7 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Use send as normal behavior in cmdCallback
e908cb0 
+ add nanoseconds param in sendLater

Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add stringify function in cdp
ffbfd36 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
send Target.attachedToTarget after Target.setAutoAttach
5e1fe65 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Big refacto
9805710 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page domain
b124220 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.getFrameTree
a708a7f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Log domain
626fae0 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Runtime domain
e073e33 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.setLifecycleEventsEnabled
0a03dcb 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.addScriptToEvaluateOnNewDocument
86b1c85 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Emulation domain
aff2250 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Network domain
67bbd99 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier francisbouvier marked this pull request as draft April 16, 2024 08:15
@francisbouvier
Handle several JSON msg in 1 read
211fa3d 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add setFocusEmulationEnabled
26eda90 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Runtime.runIfWaitingForDebugger
36dbc28 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Allow method with sessionId and use it when appropriate (*.enable)
9e8b765 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Change Page.addScriptToEvaluateOnNewDocument
05c5d06 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Do not emit optional null value in JSON output
21afa1f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Handle sessionId in result
4d8cdc6 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Return a result in Page.getFrameTree
e59fc90 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Return sessionId in Emulation.setFocusEmulationEnabled
1620138 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add some optional params in methods
e4ae2df 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Make getParams return nullable
43a558f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add method cdp function
490eb40 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier francisbouvier marked this pull request as ready for review October 1, 2024 15:50
@francisbouvier
Add License in new cdp files
5ab1d2a 
Signed-off-by: Francis Bouvier <[email protected]>
krichprollsch
krichprollsch reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@krichprollsch krichprollsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first partial review

src/msg.zig

const std = @import("std");

// pub const MaxStdOutSize = 512; // ensure debug msg are not too long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove?

src/msg.zig Outdated Show resolved Hide resolved
src/msg.zig Outdated Show resolved Hide resolved
src/msg.zig Outdated Show resolved Hide resolved
src/msg.zig Outdated Show resolved Hide resolved
src/server.zig Outdated Show resolved Hide resolved
src/server.zig Outdated Show resolved Hide resolved
src/server.zig Outdated Show resolved Hide resolved
src/server.zig Outdated Show resolved Hide resolved
src/server.zig Outdated Show resolved Hide resolved
krichprollsch
krichprollsch reviewed Oct 2, 2024
View reviewed changes
src/cdp/cdp.zig Outdated Show resolved Hide resolved
src/cdp/cdp.zig Outdated Show resolved Hide resolved
src/cdp/cdp.zig Show resolved Hide resolved
src/cdp/cdp.zig Show resolved Hide resolved
src/cdp/cdp.zig Outdated Show resolved Hide resolved
src/browser/browser.zig Outdated Show resolved Hide resolved
src/browser/browser.zig Show resolved Hide resolved
src/browser/browser.zig Show resolved Hide resolved
src/cdp/page.zig Outdated Show resolved Hide resolved
src/cdp/page.zig Show resolved Hide resolved
@francisbouvier
Move loop outside Browser
9c913b2 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: let the caller of sendSync free the string
4c225e5 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: newSession on disposeBrowserContext
76a9034 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: handle close and re-open connection
49adb61 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: timeout mechanism
c35c09d 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: move to TCP conn
b0ff325 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: merge Cmd and Accept in Ctx
c8a91d4 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: rename buf in read_buf
cea38a1 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: simplify onInspector methods
a2f65eb 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Simplify browser session.setInspector
f9b0977 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: remove unused sendLater
15414f5 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: simplify Send I/O
ff0bbc3 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add cli options for server (host, port, timeout)
9400dd7 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: formatting
c564702 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: rename public -> jsruntime
2bc58be 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: comments typos
bf56345 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: ensure token is a string when needed in parser
0d89b98 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: ensure method action is present
eaf5c6f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: rename setInspector -> initInspector
fa4920b 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: panic if callInspector without Inspector
28593d9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: add comment for auxData param in page.navigate
e53b9d9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: return error if input does not have "size:"
17c6418 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: fix a comment on page.navigate
7ad03fb 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: add comment on hard coded ID for page.createIsolatedWorld
4b495f2 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: improve comments on reallocation
fd6c25d 
Signed-off-by: Francis Bouvier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichprollsch krichprollsch krichprollsch left review comments

Assignees
No one assigned
Labels
CDP Chrome Debug Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francisbouvier @krichprollsch