fix signature validation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I signed the ICLA. |
hatashiro
suggested changes
Sep 15, 2017
lib/middleware.ts
Outdated
| @@ -22,7 +22,7 @@ export default function middleware(config: Line.Config & Line.MiddlewareConfig): | |||
| const signature = req.headers["x-line-signature"] as string; | |||
|
|
|||
| if (!signature) { | |||
| next(); | |||
| next(new SignatureValidationFailed("no signature", signature)); | |||
There was a problem hiding this comment.
signature here may be undefined, so it is not really meaningful to pass it. How about making public signature in SignatureValidationFailed optional and just not passing it?
constructor(
message: string,
public signature?: string,
) {
|
@noraesae thank you for your review. done. |
hatashiro
approved these changes
Sep 15, 2017
|
Thanks. This change will be published with the next version, which is not yet specifically scheduled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #25