Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reading package.json from sdk code #792

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Apr 1, 2024

To support dual package, we can't use require only if we don't bundle tools like tsup, esbuild or something. (however, we don't have any plan to use them.)

Currently code like require("./package.json") is only for user-agent header.

@Yang-33 Yang-33 marked this pull request as ready for review April 2, 2024 00:30
@Yang-33 Yang-33 merged commit 9e073f3 into master Apr 2, 2024
7 checks passed
@Yang-33 Yang-33 deleted the 01-stop-reading-package-json-in-code branch April 2, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants