Replace undici's multipart/form-data parser with custom implementation in tests #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undici's parser can't parse axios' multipart/form-data request. e.g. https:/line/line-bot-sdk-nodejs/actions/runs/9362094041/job/25770215937 I don't know about the root cause. But there's an issue in the legacy client. And we plan to drop this code at the end of this year. So, at this time, we'll replace the multipart/form-data parser with our own code
tokuhirom
force-pushed
the
workaround-for-undici-issue
branch
from
8c73413
to
68f0ef9
Compare
Yang-33
approved these changes
Jun 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undici's multipart/form-data parser cannot handle Axios' multipart/form-data requests correctly. For example, see this failure: https:/line/line-bot-sdk-nodejs/actions/runs/9362094041/job/25770215937.
The root cause of this issue is unclear, but it exists in the legacy client code, which we plan to deprecate by the end of this year.
As a temporary workaround, we are replacing undici's parser with our own implementation to ensure the tests pass.
Changes:
test/client.spec.ts.