fix: fix unexpected content-length raise NumberFormatException

closes #107
lingochamp · Jul 4, 2018 · 24fac8e · 24fac8e
1 parent 788320c
commit 24fac8e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/okdownload/src/main/java/com/liulishuo/okdownload/core/Util.java b/okdownload/src/main/java/com/liulishuo/okdownload/core/Util.java
@@ -326,7 +326,13 @@ public static void assembleBlock(@NonNull DownloadTask task, @NonNull Breakpoint
  public static long parseContentLength(@Nullable String contentLength) {
  if (contentLength == null) return CHUNKED_CONTENT_LENGTH;
 
- return Long.parseLong(contentLength);
+ try {
+ return Long.parseLong(contentLength);
+ } catch (NumberFormatException ignored) {
+ Util.d("Util", "parseContentLength failed parse for '" + contentLength + "'");
+ }
+
+ return CHUNKED_CONTENT_LENGTH;
  }
 
  public static boolean isNetworkNotOnWifiType(ConnectivityManager manager) {

diff --git a/okdownload/src/test/java/com/liulishuo/okdownload/core/UtilTest.java b/okdownload/src/test/java/com/liulishuo/okdownload/core/UtilTest.java
@@ -276,6 +276,8 @@ public void assembleBlock_multiBlock() throws Exception {
  public void parseContentLength() {
  assertThat(Util.parseContentLength(null)).isEqualTo(CHUNKED_CONTENT_LENGTH);
  assertThat(Util.parseContentLength("123")).isEqualTo(123L);
+
+ assertThat(Util.parseContentLength("-")).isEqualTo(CHUNKED_CONTENT_LENGTH);
  }
 
  @Test