Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compat-table): add known compatibility to v4.0.10 #115

Closed
wants to merge 2 commits into from

Conversation

dominikdosoudil
Copy link
Contributor

So I've checked @swc/core, rspack and next.

Apparently none stable @swc/core uses the [email protected].
Not even any canary next uses [email protected].
Rspack added.

Am I right to be rather pessimistic and write down only the versions that use exact =0.101.4? I think that's the only safe way.

Btw, I don't know how often is https://plugins.swc.rs/ updated, but maybe this table might be dropped one day in favour of the list.

@andrii-bodnar
Copy link
Contributor

Btw, I don't know how often is https://plugins.swc.rs/ updated, but maybe this table might be dropped one day in favour of the list.

I was thinking about this as well. We can add this link to the readme somewhere after the compatibility table. It will be useful

@timofei-iatsenko
Copy link
Collaborator

I usually just copied whatever written in swc docs, but it seems they replaced it with the new site, so it's not an easy job now.

The problem with this site - it doesn't show our pre-release versions, because it scans only the main branch. So for v5 versions we still need to maintain this form, or change our release process to be supported by this site....

Or just left only swc_core version in the table, so user's using the website could check the compatibility manually by swc_version.

In general, I vote for dropping this table and going with whatever SWC gives us, but we need to add some note there for the users which may come from dozens of links I left in comments / discussions.

@timofei-iatsenko
Copy link
Collaborator

Am I right to be rather pessimistic and write down only the versions that use exact =0.101.4? I think that's the only safe way.

They usually wrote that as an open-ended range, and updated it when a version with breaking changes appeared.

@dominikdosoudil
Copy link
Contributor Author

The problem with this site - it doesn't show our pre-release versions, because it scans only the main branch. So for v5 versions we still need to maintain this form, or change our release process to be supported by this site....

IMG_3337

if you check the checkbox, prereleases seems to be included.

Anyway, I’m planning to keep rspack up to date in out project, so I will be able to write down version when it stops working.

@dominikdosoudil
Copy link
Contributor Author

dominikdosoudil commented Sep 18, 2024

I’ve suggested where to put the link in new commit but I missclicked while commiting on phone and the commit message got autocorrected 🤦 , let me fix it when I get to laptop.

EDIT: commit message fixed

@timofei-iatsenko
Copy link
Collaborator

if you check the checkbox, prereleases seems to be included.

That's awesome. Let's drop the old table the same way as swc docs did and only left a link to the site. I don't want to maintain this table by myself for other runtimes (next, swc/core). Also, notes below the table could be dropped as well.

@pd-be
Copy link

pd-be commented Sep 25, 2024

Update: looks like the SWC folks have shipped v1.7.28 that uses [email protected] swc-project/swc@6be7166

@dominikdosoudil
Copy link
Contributor Author

@timofei-iatsenko should I change something in the PR to make it acceptable? If you just wanna deprecate the table by yourself, we can close it.

@timofei-iatsenko
Copy link
Collaborator

Yes, i'm going to deprecate the table completely. Thanks for your help, i'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants