Handle string 0 in math helper #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| key = dust.helpers.tap(key, chunk, context); | ||
| operand = dust.helpers.tap(operand, chunk, context); | ||
| key = parseFloat(dust.helpers.tap(key, chunk, context)); | ||
| operand = parseFloat(dust.helpers.tap(operand, chunk, context)); |
There was a problem hiding this comment.
Do you need to do any error checking here?
There was a problem hiding this comment.
Shouldn't need to. Anything icky coerces to NaN and that's the eventual math output.
|
Looks good. Can you add some tests? |
|
I promise to add tests, but the framework inside -helpers doesn't support testing log messages. I'll port that part over from main, but I don't want to do it as part of this PR. Tests already exist for div by 0 and such-- the only test that doesn't exist is that the correct message is logged. Is OK? |
|
Works for me. |
prashn64
added a commit
that referenced
this pull request
Mar 7, 2015
Handle string 0 in math helper and add toint to the params for @math.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbitrotted #54