Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for 1.7 #129

Merged
merged 12 commits into from
Apr 18, 2015
Merged

Refactor for 1.7 #129

merged 12 commits into from
Apr 18, 2015

Conversation

sethkinast
Copy link
Contributor

All the little changes that you don't want to do until there's a new release.

Depends on #127.

  • Remove {@default}
  • Remove internal uses of dust.helpers.tap in favor of Context#resolve
  • {@size} evaluates Dust bodies using Context#resolve
  • A whole lot of cleanup

@sethkinast
Copy link
Contributor Author

Oh, and the tests won't pass until linkedin/dustjs#622 is into a new core release.

Seth Kinast added 12 commits April 17, 2015 17:15
We know that dust.log will always be available due to the versioning policy
Short-circuiting had an incorrect behavior where `{:else}` blocks would be invoked.
Remove `type="context"`; you should just pass the key directly and there was no test for it anyways
Don't expose `filterOpType` as a param; you might clobber a real param
Like other helpers, allow `key` to be undefined as long as it was provided.
sethkinast added a commit that referenced this pull request Apr 18, 2015
@sethkinast sethkinast merged commit 5b36bd5 into LinkedInAttic:master Apr 18, 2015
@sethkinast sethkinast deleted the towards-1.7 branch April 27, 2015 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant