Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate truth test bodies inside a @select before resolving the select. #135

Merged
merged 2 commits into from
Apr 28, 2015

Conversation

sethkinast
Copy link
Contributor

Fixes #134

@smfoote
Copy link
Contributor

smfoote commented Apr 27, 2015

Does this fix the nested @eq case? Your test case doesn't have any nesting, and it looks like your check is too late. I'm not way familiar with this code, so I'm just trying to sanity check.

@sethkinast
Copy link
Contributor Author

The test code has nesting yeah. The Correct! block is nested.

@smfoote
Copy link
Contributor

smfoote commented Apr 27, 2015

Dang it. Apparently I need indentation to read code. Carry on.

@sethkinast sethkinast force-pushed the nested-truth branch 3 times, most recently from 9167dfd to 69d1173 Compare April 27, 2015 18:34
@sethkinast
Copy link
Contributor Author

I think at some point this needs re-architected. There's already another failing edge case-- putting sections inside your select will break the select.

A better solution would be a select registry inside context.global and generating an ID for your select. I'll work on this sometime.

@sethkinast
Copy link
Contributor Author

(Sections inside a select has never worked btw, it's not something new in 1.7 or 1.6)

prashn64 added a commit that referenced this pull request Apr 28, 2015
Evaluate truth test bodies inside a @select before resolving the select.
@prashn64 prashn64 merged commit 5b363ab into LinkedInAttic:master Apr 28, 2015
@sethkinast sethkinast deleted the nested-truth branch April 29, 2015 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature regression in 1.7.0, logic helpers ignored in select bodies
3 participants