Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error Reported Using grunt-sass Version 1.1.0 #69

Closed
tlattimore opened this issue Oct 13, 2015 · 5 comments
Closed

Fatal Error Reported Using grunt-sass Version 1.1.0 #69

tlattimore opened this issue Oct 13, 2015 · 5 comments

Comments

@tlattimore
Copy link

When following Grunt integration I am getting this error reported:

Fatal error: Arguments to path.resolve must be strings

Steps to reproduce:

Add the following to your package.json

{
  "devDependencies": {
    "eyeglass": "0.6.3",
    "grunt": "0.4.5",
    "grunt-sass": "1.1.0"
  }
}

Create a file named Gruntfile.js that contains this:

'use strict';

var eyeglass = require("eyeglass");

module.exports = function(grunt) {
    grunt.initConfig({
        watch: {
            sass: {
                files: ['*.{scss,sass}', 'Gruntfile.js'],
                tasks: ['sass:dist']
            },
        },
    sass: {
      options: require("eyeglass").decorate({
        sourceMap: true
      }),
      dist: {
        files: {
          'style.css': 'style.scss'
        }
      }
    }
    });
    grunt.registerTask('default', ['sass:dist']);
    grunt.loadNpmTasks('grunt-sass');
};

Create a file named style.scss with the following:

.title {
    content: 'Eyeglass is Awesome!';
}

Than run:

grunt
@eoneill
Copy link
Contributor

eoneill commented Oct 16, 2015

What versions of things are you using?

I was able to successfully run your code with the following:

@tlattimore
Copy link
Author

Sorry, @eoneill. I should have my package.json to this.

I was running grunt-sass version 1.1.0 but when I roll back to 1.0.0 I can no longer replicate this error and eyeglass appears to be working correctly. I will update the issue description to reflect this.

I am not sure if this should be left open, or whether it is an issue that should be filed against grunt-sass?

@tlattimore tlattimore changed the title Fatal Error Reported Using Grunt Fatal Error Reported Using grunt-sass Version 1.1.0 Oct 29, 2015
@eoneill
Copy link
Contributor

eoneill commented Oct 29, 2015

Ah, I missed that part in your initial report. The issue is probably that [email protected] is using node-sass@^3.4.0. Unfortunately, 3.4.0 (and 3.4.1) contain a breaking change that prevents eyeglass from working correctly: sass/node-sass#1220

The good news, this should be fixed in [email protected] in the next few days. Until then, use [email protected]. I'll keep this ticket open until 3.4.2 lands, at which point [email protected] should work.

@tlattimore
Copy link
Author

Thanks for clarifying this, @eoneill! 👍

@eoneill
Copy link
Contributor

eoneill commented Nov 15, 2015

resolved with [email protected] and [email protected]

@eoneill eoneill closed this as completed Nov 15, 2015
chriseppstein pushed a commit that referenced this issue Jan 29, 2019
Disable persistent cache in CI by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants