Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trino-spi.jar in distribution #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove trino-spi.jar in distribution #143

wants to merge 3 commits into from

Conversation

weijiii
Copy link
Contributor

@weijiii weijiii commented May 6, 2023

Summary

  • The plugin class loader in Trino delegates to the server class loader to handle the namespace io.trino.spi. The distribution should not contain trino-spi jar.

@weijiii weijiii marked this pull request as ready for review May 6, 2023 01:38
Jing-Wei added 2 commits May 8, 2023 10:17
Remove trino-main dependency in FunctionBinding
7e43f07
Remove trino-main dependency
7cabc90 
- io.trino.util.Reflection.methodHandle
- io.trino.operator.scalar.ChoicesSpecializedSqlScalarFunction;
We can remove them by re-implementing the logic in upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weijiii