Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging task for Trino with Gradle 7 #147

Merged
merged 1 commit into from
May 15, 2023

Conversation

yiqiangin
Copy link
Contributor

Code Changes

  • As the jars generated for Trino is generated by the class of ThinJarPackaging and DistributionPackaging, making some code changes in both classes on how to generate the packaging task, so the jars generated from those packaging task can be published as artifacts with Gradle 7.

Tests
cd transport
./gradlew clean build
cd transportable-udfs-example
./gradlew clean build

test a UDF MP (e.g. standard-udfs-marketing) with a locally-built transport-plugin
mint build
mint release
the content about the artifacts shown in buildspec.json include all jars

"artifacts": {
      "marketing-std-udf": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:hive": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:javadoc": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:sources": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:spark_2.11": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:spark_2.12": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:trino-dist-thin": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7",
      "marketing-std-udf:trino-thin": "ivy:/com.linkedin.standard-udfs-marketing/marketing-std-udf/1.0.7"
    }

@yiqiangin yiqiangin requested review from aastha25 and ljfgem May 12, 2023 21:15
@aastha25
Copy link
Contributor

LGTM!
could you link any gradle 7 documentation for reference in the PR description? That would explain how the new configurations enabled jar publishing.

@yiqiangin
Copy link
Contributor Author

LGTM! could you link any gradle 7 documentation for reference in the PR description? That would explain how the new configurations enabled jar publishing.

This solution was figured out by the engineer from our internal Gradle team. It was recorded in an internal Jira ticket. I am afraid there is no public Gradle 7 documentation about this issue now.

Copy link
Contributor

@aastha25 aastha25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document this process internally for future reusability.

@yiqiangin
Copy link
Contributor Author

Let's document this process internally for future reusability.

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants