Replace procinfo with procfs

[pranoyk]

This PR will replace procinfo crate which is not maintained for over 5 years with procfs.

Signed-off-by: Pranoy Kumar kundu [email protected]

fixes - linkerd/linkerd2#10819

[mateiidavid]

Left a few comments :)

[mateiidavid]

Thanks @pranoyk for the work so far. This LGTM. I suspect we'll bump into some issues with deny since we're pulling in the same transitive dependency with two separate versions. We'll probably need to add a rule for it. There's a typo in the manifest so let's see if CI complains once that's fixed.

Also, one of the commits seems to be improperly signed. Can you please confirm you agree to making this contribution?

Thanks!

[pranoyk]

I agree to the DCO for all the commits in this PR.

[mateiidavid]

Nice. Seems like it's a net change.

+54 −54 

LGTM, pretty clean. Bit of a scary change to switch deps but I think it'll be fine. Thanks!

[pranoyk]

@mateiidavid I was just wondering if we expect any more changes on this since it's being approved but not yet merged.
Do let me know if we are expecting anything else on this. :)

[mateiidavid]

@mateiidavid I was just wondering if we expect any more changes on this since it's being approved but not yet merged. Do let me know if we are expecting anything else on this. :)

Hey, typically we expect more than one reviewer even if the review protection rules have been met. In this case, we're doing a change that swaps out dependencies so it might be more contentious than say a typo or dependency bump. I'm going to wait for one more review here before merging.

[hawkw]

looks good to me!

[hawkw]

it might be worth opening a PR upstream to update procfs' dependency on rustix? then, we would be able to remove this.

[pranoyk]

So the latest version of rustix is 0.38.0
If we are planning to upgrade then should we upgrading the rustix version for both the dependencies ? Or shall we ignore it for now ?

[hawkw]

Ah, sorry, I didn't see this. It would be ideal to get both dependencies on the latest rustix. That isn't a blocker for merging this PR, but it could be nice to kick off.

[pranoyk]

Yes, it would be great. But help me understand something, I just cannot see where we are using the tempfile crate in our code base (this is another crate that uses rustix and the reason why we need to add it into deny.toml). I might be making a mistake here but in case we are not using it I can go ahead and remove it.

[hawkw]

It looks like tempfile is a transitive dependency of prost-build, which is used for compiling protobufs. This is a build-time dependency, so it's not actually used by the proxy itself. Instead, it's used when building the proxy, to generate Rust code from protocol buffer files.

We can determine where a transitive dependency comes from by using cargo tree. If we pass the --invert flag to cargo tree, we get a tree whose root is the named crate and whose leaves are the crates that depend on that crate. For tempfile, it looks like this:

$ cargo tree --package tempfile --invert
tempfile v3.5.0
└── prost-build v0.11.8
    └── tonic-build v0.8.4
        └── tools v0.1.0 (/home/eliza/Code/linkerd2-proxy/tools)
        [dev-dependencies]
        └── opencensus-proto v0.1.0 (/home/eliza/Code/linkerd2-proxy/opencensus-proto)
            └── linkerd-opencensus v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/opencensus)
                ├── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app)
                │   ├── linkerd-app-integration v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/integration)
                │   └── linkerd2-proxy v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd2-proxy)
                └── linkerd-app-core v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/core)
                    ├── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app) (*)
                    ├── linkerd-app-admin v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/admin)
                    │   └── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app) (*)
                    │   [dev-dependencies]
                    │   └── linkerd-app-integration v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/integration)
                    ├── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway)
                    │   └── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app) (*)
                    ├── linkerd-app-inbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/inbound)
                    │   ├── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app) (*)
                    │   ├── linkerd-app-admin v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/admin) (*)
                    │   └── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway) (*)
                    │   [dev-dependencies]
                    │   └── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway) (*)
                    ├── linkerd-app-integration v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/integration)
                    ├── linkerd-app-outbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/outbound)
                    │   ├── linkerd-app v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app) (*)
                    │   └── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway) (*)
                    │   [dev-dependencies]
                    │   └── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway) (*)
                    └── linkerd-app-test v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/test)
                        ├── linkerd-app-inbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/inbound) (*)
                        ├── linkerd-app-integration v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/integration)
                        └── linkerd-app-outbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/outbound) (*)
                        [dev-dependencies]
                        ├── linkerd-app-gateway v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/gateway) (*)
                        ├── linkerd-app-inbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/inbound) (*)
                        └── linkerd-app-outbound v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/outbound) (*)
    [dev-dependencies]
    └── linkerd-transport-header v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/transport-header)
        └── linkerd-app-core v0.1.0 (/home/eliza/Code/linkerd2-proxy/linkerd/app/core) (*)

[hawkw]

i think if we moved this from a skip section to a skip_tree section, we wouldn't need the separate entry for linux-raw-sys.