Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add region_info module #590

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Add region_info module #590

merged 5 commits into from
Oct 2, 2024

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to add region_info module. Addressing the need for users to access information about a specific region.

✔️ How to Test

make TEST_ARGS="-vvv region_info" test
---
- name: Create a Linode instance
  hosts: localhost
  gather_facts: no
  tasks:
    - name: Get Info of a Linode Region
      linode.cloud.region_info:
        id: us-mia

@zliang-akamai zliang-akamai requested a review from a team as a code owner September 25, 2024 21:33
@zliang-akamai zliang-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team September 25, 2024 21:33
@zliang-akamai zliang-akamai mentioned this pull request Sep 25, 2024
Merged
lgarber-akamai
lgarber-akamai approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my local testing, nice work!

yec-akamai
yec-akamai reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally! Just a small comment:

plugins/module_utils/linode_common.py Outdated Show resolved Hide resolved
jriddle-linode
jriddle-linode approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally as expected LGTM.

@zliang-akamai zliang-akamai merged commit 19081de into linode:dev Oct 2, 2024
4 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/region-info branch October 2, 2024 18:22
@jriddle-linode jriddle-linode added the new-feature for new features in the changelog. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@yec-akamai yec-akamai Awaiting requested review from yec-akamai

Assignees
No one assigned
Labels
new-feature for new features in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zliang-akamai @jriddle-linode @lgarber-akamai @yec-akamai