Account for LUKS headers in instance_config_disk test #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
testing
lgarber-akamai
requested review from
zliang-akamai and
ezilber-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Oct 7, 2024
zliang-akamai
approved these changes
Oct 8, 2024
|
Thanks for updating the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request updates
instance_config_diskintegration test to account for the implicit 17mb LUKS header on LDE-enabled instances.I'm not entirely sure why this wasn't failing before but it might be related to more regions being supported by LDE. (?)
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Integration Testing