Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve configuration resources by labels #2772

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 9, 2024

Description

This PR fixes a bug in Liqoctl where Configuration resources were retrieved by name instead of labels.

It also makes private the functions that forge default names on Kubeconfig, Nonce and SignedNonce resources.

@fra98 fra98 added the kind/bug Something isn't working label Oct 9, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 marked this pull request as draft October 9, 2024 09:10
@fra98 fra98 changed the title fix: retrieve configurations resources by labels fix: retrieve configuration resources by labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants